Problem/Motivation

Fix code style (cspell, phpstan) and phpunit. See GitLab CI.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

anybody created an issue. See original summary.

sapnil_biswas made their first commit to this issue’s fork.

sapnil_biswas’s picture

Status: Active » Needs review

@anybody marking for review, please have a look at it when you have time

anybody’s picture

Status: Needs review » Needs work

Thanks @sapnil_biswas. I left some comments. Some of these changes are unclear to me. Was it done using AI?

anybody’s picture

sapnil_biswas’s picture

@anybody Thanks for the feedback. The PR wasn't generated through AI, I tried review it through AI once that might have caused the errors i will get them rectified

sapnil_biswas’s picture

Status: Needs work » Needs review

I have force-pushed the version before the AI review please let me know if there is anything over the board or requires refinement

dimilias made their first commit to this issue’s fork.

dimilias’s picture

Assigned: Unassigned » dimilias
Issue tags: +DevDaysAthens2026

@anybody, normally I should not take novice ticket, I am just showcasing to some colleagues how the ddev and ddev modul contrib add-on works (mentoring for DDD2026) so I took it up to fix the minor issues.

anybody’s picture

Thanks @dimilias what about the existing MR!15?

dimilias’s picture

@anybody I don't really mind. I didn't want to write on top of that. The AI review indeed shows that the code can be further improved. I provided only the minimum required changes for tests to go green and I didn't want to step on the previous MR only because there are changes there I find uneeded (and possibly LLM assisted :/)

To be fair though, as I said, this is part of mentoring work and I wouldn't mind if I didn't even receive credit for this. It can go to sapnil_biswas, it is up to you. Or as part of demonstration, you can even disregard my MR with all due respect.

:) Leaving it to you.

dimilias’s picture

Assigned: dimilias » Unassigned
dimilias’s picture

btw, @anybody, please, feel free to refactor my MR on top of MR!15. I can quickly do that.

anybody’s picture

Thanks @dimilias

btw, @anybody, please, feel free to refactor my MR on top of MR!15. I can quickly do that.

Yes it would be great to have a best practice final one, which I can review and merge simply. Of course, you'll all be credited!

Thank you for your help!

dimilias’s picture

@anybody I have updated the current branch.
Notes:
* I only kept the bare minimum necessary to fix the tests.
* I kept, however, a small typo which is in the phpdoc and don't think it makes a difference.
* Even though the previous commit had attribute declaration for the dataprovider, I kept the legacy @dataProvider because the module does not have a composer.json and the info file shows support for ^8 so I wanted to be on the safe side.
* About

btw, @anybody, please, feel free to refactor my MR on top of MR!15

, I forgot to add a 2 words that makes it much different. It is "feel free to ASK ME to refactor.." :P

anybody’s picture

I think this should be reviewed and merged with priority.

dieterholvoet made their first commit to this issue’s fork.

dieterholvoet’s picture

Status: Needs review » Fixed

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.