Summary

Shorturl #3584485 introduces a visit event system where the middleware collects all X-Shorturl-* response headers generically and dispatches a ShortUrlVisitEvent. A VisitDatabaseSubscriber writes the fields to the database.

This makes DomainAwareVisitMiddleware unnecessary — the base middleware now handles X-Shorturl-Domain-Id automatically. The DomainAwareVisitTracker is still needed for the direct trackVisit() service path.

Changes

  • Remove DomainAwareVisitMiddleware (no longer needed)
  • Remove middleware class swap from DomainShorturlServiceProvider
  • Rename header from X-Shorturl-DomainId to X-Shorturl-Domain-Id (maps to domain_id column via hyphen-to-underscore conversion)
  • Update middleware tests to use base ShortUrlVisitMiddleware

Issue fork domain_shorturl-3584504

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mably created an issue. See original summary.

mably opened merge request !5

mably’s picture

mably commented
Status: Active » Needs review

  • mably committed b8443331 on 1.x 
    task: #3584504 Migrate to shorturl visit event system and remove...
mably’s picture

mably commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.