Problem/Motivation

Config in config/install, config/optional and config/schema are parsed but not directly in config/ which is how recipes ship them.

Steps to reproduce

Proposed resolution

  • Parse config in recipes.
  • Add tests.

Remaining tasks

User interface changes

API changes

Data model changes

LLM disclosure

LLM was used to asses the situation and develop a solution. The solution was manually simplified heavily though to avoid code duplication.

Issue fork potx-3583987

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gábor hojtsy created an issue. See original summary.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Not just test, but we need to fix it too apparently :D Recipes ship config in config/ not config/install or config/optional and potx only parses the other two.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Test that config inside recipes is parsed for translatable strings » Config inside recipes it not parsed at all (and not tested either)
Category: Task » Bug report
Priority: Normal » Critical
Issue summary: View changes
Status: Active » Needs work

gábor hojtsy opened merge request !50

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Config inside recipes it not parsed at all (and not tested either) » Config inside recipes is not parsed at all in potx (and not tested either)

Fix title typo.

gábor hojtsy opened merge request !51

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Needs review
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Ran the test only jobs too and they fail as expected :) I think this is good to go.

  • gábor hojtsy committed c0758e64 on 7.x-3.x 
    fix: #3583987 Config inside recipes is not parsed at all in potx (and...

  • gábor hojtsy committed b88154c9 on 2.x 
    fix: #3583987 Config inside recipes is not parsed at all in potx (and...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.