Problem/Motivation

We skip a number of deprecations in .deprecation-ignore.txt but some of these are outdated or could be tightened up.

Also, there's a number of tests that are tagged with the #[IgnoreDeprecations] attribute, but no deprecations are actually triggered during the test execution.

Proposed resolution

  • remove obsolete lines from .deprecation-ignore.txt
  • remove #[IgnoreDeprecations] from tests that do not trigger deprecations
  • add @phpstan-ignore annotations to prevent PHPStan errors in code that by removing #[IgnoreDeprecations] is no longer resolved as deprecated scope

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3582888

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Related issues: +#3523614: [CI] Collect and report deprecation statistics and details

mondrake opened merge request !15334

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Not entirely sure how to test this without going into every IgnoreDeprecation instance but pipeline agreed so will go with that.

amateescu’s picture

amateescu commented
Status: Reviewed & tested by the community » Fixed

Committed 4f89536 and pushed to main. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

amateescu closed merge request !15334

  • amateescu committed 4f89536d on main 
    task: #3582888 Tidy up and tighten deprecation ignores and tests marked...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.