Problem/Motivation

Neither @catch nor I can figure out why this is necessary and it breaks converted kernel tests.

Let's try removing it.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3582386

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joachim created an issue. See original summary.

joachim’s picture

joachim commented
Status: Active » Needs review

joachim opened merge request !15295

catch’s picture

catch
he/him
Primary language English
commented

This was added in #3090659: Make a way for help topics to generate links only if they work and are accessible which I committed. The access vs. no access behaviour in that issue was tricky and got a lot of discussion (main reason for the issue), but the absolute link generation wasn't discussed at all, so I think it's probably the case that someone added it without thinking too much about it, and then no-one else thought about it either, but we didn't really need to. Let's see if the test coverage agrees though.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Needs work

That's very green. We need a docs update here. I doubt anyone will ever notice the difference, but maybe a CR just in case? Otherwise I think we should go ahead here.

joachim’s picture

joachim commented
Status: Needs work » Needs review

Where do we need docs?

EDIT nm I see it.

joachim’s picture

joachim commented
Status: Needs review » Needs work
joachim’s picture

joachim commented
Status: Needs work » Needs review

Done docs & CR.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Both the change and the CR look good, I made a tiny edit to the CR. Moving to RTBC.

godotislate closed merge request !15295

  • godotislate committed 1ab3da43 on main 
    refactor: #3582386 remove absolute from HelpTwigExtension links

By:...

  • godotislate committed b65e6289 on 11.x 
    refactor: #3582386 remove absolute from HelpTwigExtension links

By:...
godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Fixed

Committed 1ab3da4 and pushed to main and committed b65e628 and pushed to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

godotislate’s picture

godotislate
he/him
commented
Version: main » 11.x-dev

Also published the CR.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.