jCarousel for Drupal 6 is now out, and the API is pretty handy. Might be a good idea to switch to use that instead of Views Carousel implementation.

CommentFileSizeAuthor
#8 viewscarousel_revamp-358213-8.patch62.28 KBneclimdul
#7 viewscarousel_revamp-358213-7.patch62.21 KBneclimdul
#5 viewscarousel_revamp.358213.5.patch62.18 KBneclimdul
#4 viewscarouselrevamp.patch65.78 KBrobloach
#3 viewscarouseljcarousel.patch61.26 KBrobloach
#1 viewscarouseljcarousel.patch61.26 KBrobloach
#1 viewscarouseljcarousel-binary.patch63.27 KBrobloach

Comments

robloach’s picture

robloach
he/him
commented
Status: Active » Needs review
StatusFileSize
new viewscarouseljcarousel-binary.patch63.27 KB
new viewscarouseljcarousel.patch61.26 KB

Well this certainly removes quite a bit of code.............. Make sure to also delete the images. The -binary patch includes the binary files, the first one does not.

Now depends on the jCarousel module.

......Nice job on the module, it's pretty awesome. The Views 2 API is wicked.

robloach’s picture

robloach
he/him
commented

One thing that's not included in this patch is the ability to make use of the JavaScript callbacks. the jCarousel module for Drupal 6 supports the ability to send in the callback functions for initCallback, etc.... This patch doesn't allow you to set those from the View configuration. Maybe in a future patch?

robloach’s picture

robloach
he/him
commented
Priority: Normal » Critical
StatusFileSize
new viewscarouseljcarousel.patch61.26 KB

Adding this fixes a lot of issues in the Views Carousel issue queue..... Requires at least jCarousel 6.x-1.1.

robloach’s picture

robloach
he/him
commented
StatusFileSize
new viewscarouselrevamp.patch65.78 KB

Sorry, wrong patch.

neclimdul’s picture

neclimdul
He/Him
commented
StatusFileSize
new viewscarousel_revamp.358213.5.patch62.18 KB

Very cool, +1 to minimizing external libs in contrib.

Slight tweak of Rob's patch to use the dependency javascript to control this skin path field and adjusting the description to fit this.

robloach’s picture

robloach
he/him
commented
Status: Needs review » Reviewed & tested by the community
neclimdul’s picture

neclimdul
He/Him
commented
StatusFileSize
new viewscarousel_revamp-358213-7.patch62.21 KB

Found a sort of bug where if you didn't empty the custom CSS file before selecting a different theme it would still be added. Not a likely workflow but this patch still fixes it. Trivial argument validation fix so not dropping it out of RTBC.

neclimdul’s picture

neclimdul
He/Him
commented
StatusFileSize
new viewscarousel_revamp-358213-8.patch62.28 KB

the real patch

robloach’s picture

robloach
he/him
commented
Status: Reviewed & tested by the community » Fixed

Awesome work! Committed and viewscarousel 6.x-2.x-dev opened. I like how the custom skin path disappears when custom skin isn't chosen............Think we could add a hook_jcarousel_skin() to the jCarousel module or something to list the skins?

Any other problems with it should be handled in new issues.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

asak’s picture

asak commented

Note: it isn't clear from the projects page that jCarousel module is a dependency now.