Problem/Motivation

Eliminate user_form_process_password_confirm() from user.module.

Steps to reproduce

Proposed resolution

Move user_form_process_password_confirm() to UserThemeHooks. Also colocate the element_info_alter hook implementation, so those related pieces of code come together.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3582106

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

znerol created an issue. See original summary.

znerol opened merge request !15269

znerol’s picture

znerol commented
Status: Active » Needs review
sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

The MR looks fine to me.

nicxvan’s picture

nicxvan commented
Status: Needs review » Reviewed & tested by the community

I think this is ready.
Deprecation versions are correct.

Replacement is correct.

Element info alter does make sense in theme since it's documented in theme.api.php.

I wish there was a cleaner way to have helpers in hook classes, but most callbacks are in the hook class so it makes sense.

  • amateescu committed 11850806 on 11.x 
    task: #3582106 Move user_form_process_password_confirm into...

  • amateescu committed 0923b693 on main 
    task: #3582106 Move user_form_process_password_confirm into...
amateescu’s picture

amateescu commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 0923b693f15 to main and 11850806e44 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

amateescu closed merge request !15269

amateescu’s picture

amateescu commented
Version: main » 11.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.