Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
Claro theme
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
29 Mar 2026 at 09:55 UTC
Updated:
29 Sep 2026 at 07:55 UTC
Jump to comment: Most recent
Problem/Motivation
This is part of deprecating Claro.
Steps to reproduce
Proposed resolution
Change tests to use the new Admin theme, or if appropriate to use test_theme.
Includes FunctionalTests, FunctionalJavascriptTests and Nightwatch.
This excludes
- tests of the installer, those are in #3622220: Use Admin theme in installer related tests
- tests of recipes, those are in #3582101: Make Admin the default theme in profiles and recipes
Remaining tasks
Fix failing tests
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Issue fork drupal-3582098
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
quietone commentedAll the functional tests relating to testing the install fails. And since the install theme is being changed to Admin over in #3618971: Use Admin theme in installer, I pulled all those tests out.
Comment #4
quietone commentedComment #5
quietone commentedComment #6
quietone commentedComment #8
smustgrave commentedComment #9
quietone commentedComment #10
quietone commentedReviewed this and made sure that tests being done elsewhere were removed form this issue, and removed duplicate Nightwatch tests.
Now that tests are passing, setting to needs review.
Comment #11
smustgrave commentedChanges here look good. This is really coming together nicely way to go @quietone!
Comment #13
catchCommitted/pushed to main, thanks!
Moving to 11.x for backport.
Comment #15
quietone commentedIn 11.x there was a failing test, core/tests/Drupal/Tests/Core/Test/WorkAllocatorTest.php. It failed because the fixture, core/tests/fixtures/test_runner/work_allocator/complex_in.json, reference ClaroBlockFilterTest,php instead of AdminBlockFilterTest.php. That is fixed on this 11.x backport. However, it is not fixed in main, nor do I looked into why WorkAllocatorTest.php does not fail on main.
Comment #16
quietone commented11.x MR available for review.
this will need also need work as explained in #15.
Comment #17
smustgrave commentedSo seems #3588584: run-tests.sh - move suite determination from WorkAllocator to PhpUnitTestDiscovery was only reverted on 11.x which has a line assert(class_exists($class), "$class does not exist"); in 11.x that doesn't exist in main. So the 11.x appears to be a good backport but probably need another MR for main to fix that json.
Comment #19
smustgrave commentedOpened an MR for main with just the json
Comment #21
catchCommitted/pushed the backport to 11.x and the quick fix to main, thanks!