[Tracker]
Update Summary: AI Ckeditor test broken with Drupal 11.4
Short Description: Broken CI
Check-in Date: MM/DD/YYYY
Metadata is used by the AI Tracker. Docs and additional fields here.
[/Tracker]

Problem/Motivation

Atm all CI builds show a test-fail for the "next minor" AI Ckeditor test broken with Drupal 11.4

Failures:

    Install Ai CKEditor (Drupal\Tests\ai_ckeditor\Kernel\InstallAiCKEditor)
     ⚠ Module can be enabled
    
    1 test triggered 2 PHP warnings:
    
    1) /builds/project/ai/web/core/modules/ckeditor5/src/Hook/Ckeditor5Hooks.php:406
    Undefined array key "filter.format.*"

AI usage (if applicable)

[ ] AI Assisted Issue
This issue was generated with AI assistance, but was reviewed and refined by the creator.

[ ] AI Assisted Code
This code was mainly generated by a human, with AI autocompleting or parts AI generated, but under full human supervision.

[ x ] AI Generated Code
This code was mainly generated by an AI with human guidance, and reviewed, tested, and refined by a human.

[ ] Vibe Coded
This code was generated by an AI and has only been functionally tested.

Issue fork ai-3581842

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fago created an issue. See original summary.

fago opened merge request !1363

fago’s picture

fago
Primary language German
Location Vienna
commented
Issue summary: View changes
Status: Active » Needs review
harivansh’s picture

harivansh commented
Assigned: Unassigned » harivansh
harivansh’s picture

harivansh commented
Assigned: harivansh » Unassigned
Status: Needs review » Reviewed & tested by the community

Changes are alright.

Editor Module has dependency on the filter module 

name: 'Text Editor'
type: module
description: 'Provides a framework to associate text editors (like WYSIWYGs) and toolbars with text formats.'
package: Core
version: VERSION
dependencies:
  - drupal:filter
  - drupal:file
configure: filter.admin_overview

Ran test locally:
Clearing old webdriver sessions
PHPUnit 11.5.55 by Sebastian Bergmann and contributors.

Runtime: PHP 8.4.18
Configuration: /var/www/html/web/core/phpunit.xml.dist

D 1 / 1 (100%)

Time: 00:00.749, Memory: 10.00 MB

1 test triggered 13 deprecations:

1) /var/www/html/web/core/tests/Drupal/KernelTests/KernelTestBase.php:237
Kernel test classes must specify the #[RunTestsInSeparateProcesses] attribute, not doing so is deprecated in drupal:11.3.0 and will throw an exception in drupal:12.0.0. See https://www.drupal.org/node/3548485

Triggered by:

* Drupal\Tests\ai_ckeditor\Kernel\InstallAiCKEditorTest::testModuleCanBeEnabled
/var/www/html/web/modules/contrib/ai/modules/ai_ckeditor/tests/src/Kernel/InstallAiCKEditorTest.php:24

2) /var/www/html/web/core/lib/Drupal/Core/Hook/HookCollectorPass.php:634
ai_requirements without a #[LegacyRequirementsHook] attribute is deprecated in drupal:11.3.0 and removed in drupal:13.0.0. See https://www.drupal.org/node/3549685

Triggered by:

* Drupal\Tests\ai_ckeditor\Kernel\InstallAiCKEditorTest::testModuleCanBeEnabled (2 times)
/var/www/html/web/modules/contrib/ai/modules/ai_ckeditor/tests/src/Kernel/InstallAiCKEditorTest.php:24

3) /var/www/html/vendor/symfony/error-handler/DebugClassLoader.php:348
Method "Symfony\Component\Validator\ConstraintValidatorInterface::validate()" might add "void" as a native return type declaration in the future. Do the same in implementation "Drupal\ai\Plugin\Validation\Constraint\FixedValueValidator" now to avoid errors or add an explicit @return annotation to suppress this message.

Triggered by:

* Drupal\Tests\ai_ckeditor\Kernel\InstallAiCKEditorTest::testModuleCanBeEnabled
/var/www/html/web/modules/contrib/ai/modules/ai_ckeditor/tests/src/Kernel/InstallAiCKEditorTest.php:24

4) /var/www/html/vendor/symfony/error-handler/DebugClassLoader.php:348
Method "Symfony\Component\Validator\ConstraintValidatorInterface::validate()" might add "void" as a native return type declaration in the future. Do the same in implementation "Drupal\ai\Plugin\Validation\Constraint\ComplexToolItemsConstraintValidator" now to avoid errors or add an explicit @return annotation to suppress this message.

Triggered by:

* Drupal\Tests\ai_ckeditor\Kernel\InstallAiCKEditorTest::testModuleCanBeEnabled
/var/www/html/web/modules/contrib/ai/modules/ai_ckeditor/tests/src/Kernel/InstallAiCKEditorTest.php:24

5) /var/www/html/vendor/symfony/error-handler/DebugClassLoader.php:348
Method "Symfony\Component\Validator\ConstraintValidatorInterface::validate()" might add "void" as a native return type declaration in the future. Do the same in implementation "Drupal\ai\Plugin\Validation\Constraint\SimpleToolItemsConstraintValidator" now to avoid errors or add an explicit @return annotation to suppress this message.

Triggered by:

* Drupal\Tests\ai_ckeditor\Kernel\InstallAiCKEditorTest::testModuleCanBeEnabled
/var/www/html/web/modules/contrib/ai/modules/ai_ckeditor/tests/src/Kernel/InstallAiCKEditorTest.php:24

6) /var/www/html/web/core/lib/Drupal/Core/Plugin/Discovery/AttributeDiscoveryWithAnnotations.php:98
Using @EntityType annotation for plugin with ID ai_guardrail is deprecated and is removed from drupal:13.0.0. Use a Drupal\Core\Entity\Attribute\EntityType attribute instead. See https://www.drupal.org/node/3395575

Triggered by:

* Drupal\Tests\ai_ckeditor\Kernel\InstallAiCKEditorTest::testModuleCanBeEnabled
/var/www/html/web/modules/contrib/ai/modules/ai_ckeditor/tests/src/Kernel/InstallAiCKEditorTest.php:24

7) /var/www/html/web/core/lib/Drupal/Core/Plugin/Discovery/AttributeDiscoveryWithAnnotations.php:98
Using @EntityType annotation for plugin with ID ai_prompt_type is deprecated and is removed from drupal:13.0.0. Use a Drupal\Core\Entity\Attribute\EntityType attribute instead. See https://www.drupal.org/node/3395575

Triggered by:

* Drupal\Tests\ai_ckeditor\Kernel\InstallAiCKEditorTest::testModuleCanBeEnabled
/var/www/html/web/modules/contrib/ai/modules/ai_ckeditor/tests/src/Kernel/InstallAiCKEditorTest.php:24

8) /var/www/html/web/core/lib/Drupal/Core/Plugin/Discovery/AttributeDiscoveryWithAnnotations.php:98
Using @EntityType annotation for plugin with ID ai_guardrail_set is deprecated and is removed from drupal:13.0.0. Use a Drupal\Core\Entity\Attribute\EntityType attribute instead. See https://www.drupal.org/node/3395575

Triggered by:

* Drupal\Tests\ai_ckeditor\Kernel\InstallAiCKEditorTest::testModuleCanBeEnabled
/var/www/html/web/modules/contrib/ai/modules/ai_ckeditor/tests/src/Kernel/InstallAiCKEditorTest.php:24

9) /var/www/html/web/core/lib/Drupal/Core/Plugin/Discovery/AttributeDiscoveryWithAnnotations.php:98
Using @EntityType annotation for plugin with ID ai_prompt is deprecated and is removed from drupal:13.0.0. Use a Drupal\Core\Entity\Attribute\EntityType attribute instead. See https://www.drupal.org/node/3395575

Triggered by:

* Drupal\Tests\ai_ckeditor\Kernel\InstallAiCKEditorTest::testModuleCanBeEnabled
/var/www/html/web/modules/contrib/ai/modules/ai_ckeditor/tests/src/Kernel/InstallAiCKEditorTest.php:24

10) /var/www/html/web/core/lib/Drupal/Core/Hook/HookCollectorPass.php:628
ai_ckeditor_module_implements_alter without a #[LegacyModuleImplementsAlter] attribute is deprecated in drupal:11.2.0 and removed in drupal:12.0.0. See https://www.drupal.org/node/3496788

Triggered by:

* Drupal\Tests\ai_ckeditor\Kernel\InstallAiCKEditorTest::testModuleCanBeEnabled
/var/www/html/web/modules/contrib/ai/modules/ai_ckeditor/tests/src/Kernel/InstallAiCKEditorTest.php:24

11) /var/www/html/web/core/lib/Drupal/Core/Plugin/DefaultPluginManager.php:169
Not supporting attribute discovery in Drupal\key\Plugin\KeyPluginManager is deprecated in drupal:11.2.0 and is removed from drupal:12.0.0. Provide an Attribute class and an Annotation class for BC. See https://www.drupal.org/node/3395582

Triggered by:

* Drupal\Tests\ai_ckeditor\Kernel\InstallAiCKEditorTest::testModuleCanBeEnabled (3 times)
/var/www/html/web/modules/contrib/ai/modules/ai_ckeditor/tests/src/Kernel/InstallAiCKEditorTest.php:24

12) /var/www/html/web/core/lib/Drupal/Core/Plugin/Discovery/AttributeDiscoveryWithAnnotations.php:98
Using @EntityType annotation for plugin with ID key is deprecated and is removed from drupal:13.0.0. Use a Drupal\Core\Entity\Attribute\EntityType attribute instead. See https://www.drupal.org/node/3395575

Triggered by:

* Drupal\Tests\ai_ckeditor\Kernel\InstallAiCKEditorTest::testModuleCanBeEnabled
/var/www/html/web/modules/contrib/ai/modules/ai_ckeditor/tests/src/Kernel/InstallAiCKEditorTest.php:24

13) /var/www/html/web/core/lib/Drupal/Core/Plugin/Discovery/AttributeDiscoveryWithAnnotations.php:98
Using @EntityType annotation for plugin with ID key_config_override is deprecated and is removed from drupal:13.0.0. Use a Drupal\Core\Entity\Attribute\EntityType attribute instead. See https://www.drupal.org/node/3395575

Triggered by:

* Drupal\Tests\ai_ckeditor\Kernel\InstallAiCKEditorTest::testModuleCanBeEnabled
/var/www/html/web/modules/contrib/ai/modules/ai_ckeditor/tests/src/Kernel/InstallAiCKEditorTest.php:24

OK, but there were issues!
Tests: 1, Assertions: 1, Deprecations: 13, PHPUnit Deprecations: 2.

Moving to RTBC.

  • fago committed 4d1a057f on 1.4.x 
    test: #3581842 Fix AI Ckeditor test broken with Drupal 11.4

By: fago

  • fago committed 58560a17 on 1.x 
    test: #3581842 Fix AI Ckeditor test broken with Drupal 11.4

By: fago...

  • fago committed 15730e38 on 1.3.x 
    test: #3581842 Fix AI Ckeditor test broken with Drupal 11.4

By: fago...

  • fago committed b40bfdc2 on 2.x 
    test: #3581842 Fix AI Ckeditor test broken with Drupal 11.4

By: fago...

  • fago committed 1c8a42c5 on 2.0.x 
    test: #3581842 Fix AI Ckeditor test broken with Drupal 11.4

By: fago...
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Reviewed & tested by the community » Fixed

thx, CI agrees also, merged then!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • fago committed 53ac5960 on 1.2.x 
    test: #3581842 Fix AI Ckeditor test broken with Drupal 11.4

By: fago...

  • fago committed 58560a17 on 3574181-assistant-agent-form 
    test: #3581842 Fix AI Ckeditor test broken with Drupal 11.4

By: fago...

  • fago committed b40bfdc2 on 2.0.x 
    test: #3581842 Fix AI Ckeditor test broken with Drupal 11.4

By: fago...