Problem/Motivation

The function user_cookie_save() is used once in core, user_cookie_delete() is not used at all.

Steps to reproduce

Proposed resolution

Deprecate and remove them. Cookies should be set/deleted directly on the Symfony Response object.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#10 interdiff.txt2.49 KBznerol

Issue fork drupal-3581569

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

znerol created an issue. See original summary.

znerol opened merge request !15217

znerol’s picture

znerol commented
Status: Active » Needs review
dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

I'm going to RTBC this because I didn't find any real problems with the MR. I wasn't sure if it was OK to not mention the use of Symfony request objects in the deprecation messages. But I couldn't find any precedent for mentioning Symfony replacements in other 11.x deprecation messages. So I decided to not flag it as a problem.

The change record implicitly shows an example of replacing user_cookie_delete(). There are several uses of the function in contrib. The committer should consider whether we need a separate, explicit example for replacing the delete function.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

I've a comment added to the MR.

catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to main and cherry-picked to main, thanks!

This will need a backport MR for 11.x

catch closed merge request !15217

  • catch committed fd7e1c2d on main 
    task: #3581569 Remove user_cookie_save() and user_cookie_delete()

By:...

znerol opened merge request !15447

znerol’s picture

znerol commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new interdiff.txt2.49 KB

Backport to 11.x. Had to resolve a conflict in SystemController constructor. Interdiff attached.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

I compared the backport to the original MR. The port is a duplicate with the exception of the addition of the docblock @param annotation since the docblock hasn't been deleted from the 11.x branch. It looks good to me.

godotislate closed merge request !15447

  • godotislate committed 57bf4fed on 11.x 
    task: #3581569 Remove user_cookie_save() and user_cookie_delete()

By:...
godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Fixed

Committed 57bf4fe and pushed to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone’s picture

quietone commented

Publish change record and set branch version.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.