Problem/Motivation

I see that the module follows very old PHP standard practices, for example it doesn't follow the function return type hinting, among other features that need to be added

More information about Drupal's coding standards

Steps to reproduce

Look into the module's source code, it is using outdated PHP practices.

Proposed resolution

Upgrade the module follow recent standard practices for writing more robust PHP code.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

danrod created an issue. See original summary.

danrod’s picture

Issue tags: +Novice
yusuf_khan’s picture

Assigned: Unassigned » yusuf_khan

Working on it

yusuf_khan’s picture

yusuf_khan’s picture

Assigned: yusuf_khan » Unassigned
yusuf_khan’s picture

Status: Active » Needs review

jerech made their first commit to this issue’s fork.

jerech’s picture

Status: Needs review » Reviewed & tested by the community
danrod’s picture

Status: Reviewed & tested by the community » Needs review

It is customary not to set the issue to RTBC to your own code, setting this to "Needs Review" again, I'll review the code sometime today.

danrod’s picture

I finally tested this (calendar event edit/view/delete), configuration form, cron task and the import calendar items functionality and works as expected, I'll merge this to the 3.0.x branch. Thanks a lot to everyone involved on this issue.

danrod’s picture

Status: Needs review » Reviewed & tested by the community
danrod’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.