Problem/Motivation

One of the slowest functional tests. See https://git.drupalcode.org/project/drupal/-/jobs/9061843

Several of the methods visit the same page without making any changes and assert some text/markup, that can all be one method so don't have to install Drupal multiple times to then check an identical page.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3581116

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch opened merge request !15185

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
dcam’s picture

dcam commented
Status: Needs review » Needs work

Pre-patch results:

Time: 01:45.695, Memory: 8.00 MB

OK, but some tests were skipped!
Tests: 12, Assertions: 121, Skipped: 1.

Post-patch results:

Time: 01:23.073, Memory: 8.00 MB

OK, but some tests were skipped!
Tests: 9, Assertions: 106, Skipped: 1.

I only ran the test once on each branch, but a 22 second speed-up is significant enough to not be anomalous.

I checked for other tests that might be merged into this new, combined function. I didn't find any.

None of the combined functionality is likely to interfere with itself. It consists entirely of loading the admin/modules page and then asserting things in the output.

I left one comment on the MR because I believe that the function's docblock needs to be updated.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review

Applied the suggestion on the MR, that looks good.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

The test failure is unrelated - one I've already seen randomly fail today. This MR looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed cf10d21ff9b to main and 14807990998 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed 14807990 on 11.x 
    perf: #3581116 Speed up DependencyTest

By: catch
By: dcam
(cherry...

  • alexpott committed cf10d21f on main 
    perf: #3581116 Speed up DependencyTest

By: catch
By: dcam

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.