Problem/Motivation

The module provides NavigationExtraPlugin plugins where the icon is hardcoded in the plugin. It would be very nice if we allowed to customise those icons.

Steps to reproduce

N/A

Proposed resolution

Use the UI Icons module as provider for selecting the icons but make it a soft dependency so its not required to install the module. So customisation is only possible if the module is installed.Make sure the code does not break when uninstalling UI Icons afterwards.

Provide an icon selector on each NavigationExtraPlugin when the plugin is enabled.
Overwrite the hard coded icon when there is an icon, fall back on the default when there is no icon selected.

Remaining tasks

See above.

User interface changes

There will be an icon select method when the UI icons module is installed.

API changes

None

Data model changes

Schema addition for the icon.

Issue fork navigation_extra-3580836

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tim-diels created an issue. See original summary.

jyrkimouton made their first commit to this issue’s fork.

jyrkimouton’s picture

jyrkimouton commented
Status: Active » Needs review

jyrkimouton opened merge request !33

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented

The icon definition should be done differently. Maybe leverage the code from #3493153: Config schema miss?

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Related issues: +#3493153: Config schema miss

tim-diels changed the visibility of the branch 3580836-allow-the-main to hidden.

tim-diels changed the visibility of the branch 3580836-allow-the-main to active.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Fixed » Closed (fixed)