I use the module very successfully to alongside the Gin admin theme to trigger Gin-style modal dialogs for quite a number of core admin paths but this one...

/admin/config/development/logging

Stubbornly refused to play ball.

The definition is...

admin_dialogs_logging_and_errors_defn

But the result is (displayed in the front end theme)...

admin_dialogs_logging_and_errors_result

CommentFileSizeAuthor
admin_dialogs_logging_and_errors_result.png31.39 KBsirclickalot
admin_dialogs_logging_and_errors_defn.png45.69 KBsirclickalot

Comments

sirclickalot created an issue. See original summary.

minnur’s picture

minnur commented
Status: Active » Closed (works as designed)

gin theme wont work in dialogs outside of admin theme paths. Looks like you are trying to use dialogs in public theme - dialogs inherit your non-admin theme styles.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

sirclickalot’s picture

sirclickalot
Primary language English
Location Somerset, UK
commented

But the path here is clearly an 'admin' path, it is: /admin/config/development/logging

sirclickalot’s picture

sirclickalot
Primary language English
Location Somerset, UK
commented
Status: Closed (works as designed) » Active

Reopening as per my last comment.

@minnur Unless I thoroughly misunderstand your point?

minnur’s picture

minnur commented

Yes the path is correct, but if you are trying to open logging path from non-admin page the dialog will inherit non-admin theme. Styles are not applied by path. So if you go to admin page and try open logging again you would see Gin theme (if you are using Gin as admin theme)

Even if I make it work with Gin theme, others may want different styling for dialogs on no-admin pages so we end up with the same problem as yours.

Does this explain the problem and why you can't see admin styles applied to dialogs in non-admin pages?

sirclickalot’s picture

sirclickalot
Primary language English
Location Somerset, UK
commented

OK, I get you now, thankyou for the explanation.

I think this is was my only example of where I was actually launching an admin page from the front end.

How about offering a 'Use admin theme' checkbox which forces the current admin theme into action?
The actual forced application of the theme should dependent on current user's permission to 'View the administration theme'.

Would be a nest UX touch in my opinion and would keep everyone happy.

Thank you

minnur’s picture

minnur commented

I tried to add a new checkbox, unfortunately its not something I would like to support or maintain. So many issues causing adding admin theme dialog styles.. I suggest you add admin dialog styles to your theme instead so it dialogs properly rendered.
I would have to close this unless you are willing to try implement this feature or someone else can also take a look.

minnur’s picture

minnur commented

One possible solution I may consider is completely disable all admin_dialog settings in frontend, so dialogs would only work when in admin paths. I think this way it would be less confusing and more like its expected behaviour.