Problem/Motivation

Coming from #3566536: [meta] eliminate core .module files

Proposed resolution

Core uses this function only once on the theme layer. Move its logic in FilterThemeHooks as protected method and deprecated it.

Remaining tasks

None.

User interface changes

None.

Introduced terminology

None.

API changes

None.

Data model changes

None.

Issue fork drupal-3580662

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Issue tags: +Needs change record
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Issue tags: -Needs change record
Parent issue: #455724: Deprecate check_markup() » #3566536: [meta] eliminate core .module files

Added CR, fixed parent issue.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Issue summary: View changes

claudiu.cristea opened merge request !15160

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Assigned: claudiu.cristea » Unassigned
Status: Active » Needs review

Ready for review

nicxvan’s picture

nicxvan commented
Status: Needs review » Reviewed & tested by the community

This is actually a super easy one, we don't delete the content of the function since the replacement is protected.

I think that makes sense.

The deprecation messages are the correct version and consistent.

catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to main and cherry-picked to main, thanks!

Will need a backport MR.

catch closed merge request !15160

  • catch committed dcfcfab6 on main 
    task: #3580662 Deprecate _filter_tips()

By: claudiu.cristea
By: nicxvan

claudiu.cristea opened merge request !15187

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Patch (to be ported) » Needs review

I've created https://git.drupalcode.org/project/drupal/-/merge_requests/15187 for Drupal 11.x

nicxvan’s picture

nicxvan commented
Status: Needs review » Reviewed & tested by the community

I compared them, the reason it didn't apply was due to another deprecation that hadn't been removed yet in 11.x for the parameter.

Otherwise it is identical.

  • catch committed 5612209a on 11.x 
    task: #3580662 Deprecate _filter_tips()

By: claudiu.cristea
By: nicxvan

catch closed merge request !15187

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.