Problem/Motivation

After implementing the WorkspaceSwitchEvent event from #3553581: Slim down WorkspaceManager in the contrib WSE module, I realized that some negotiators need to act differently when a workspace is switched permanently (setActiveWorkspace() and switchToLive()) vs. switched temporarily (executeInWorkspace() and executeOutsideWorkspace()).

See #3571367: Preview cookie gets dropped if entity workspace status field on the page for details.

Proposed resolution

Add a $isTemporary flag to WorkspaceSwitchEvent.

Remaining tasks

Review.

User interface changes

Nope.

Introduced terminology

Nope.

API changes

Nope.

Data model changes

Nope.

Release notes snippet

N/A.

Issue fork drupal-3580403

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

amateescu created an issue. See original summary.

amateescu opened merge request !15151

amateescu’s picture

amateescu commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Had this one opened from yesterday and was waiting for the new pipleline to pass.

Ran the test-only since I started a new one https://git.drupalcode.org/issue/drupal-3580403/-/jobs/9015428

Change seems straight forward enough.

catch closed merge request !15151

  • catch committed abd4d6bf on 11.x 
    task: #3580403 Add a 'is temporary' flag to WorkspaceSwitchEvent

By:...

  • catch committed 222a5555 on main 
    task: #3580403 Add a 'is temporary' flag to WorkspaceSwitchEvent

By:...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Makes sense. Committed/pushed to main and 11.x, thanks! No 11.3 backport because this changes protected methods.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.