Problem/Motivation

Core themes
Convert the missed hooks and move the remaining functions to the correct hook class
claro.theme is addressed here: #3579899: Remove remaining claro.theme functions

  • olivero.theme
    • _olivero_hex_to_hsl
  • stable9.theme
    • stable9_preprocess_item_list__search_results
    • stable9_preprocess_views_view

Test themes

  • access_test.theme
  • test_installer_theme.theme
    • test_installer_theme_form_install_select_language_form_alter
  • test_missing_base_theme.theme
  • views_test_checkboxes_theme.theme
    • views_test_checkboxes_theme_form_views_exposed_form_alter

Steps to reproduce

Proposed resolution

Convert to trait and delete
_olivero_hex_to_hsl has no contrib uses
https://search.tresbien.tech/search?q=_olivero_hex_to_hsl

Convert and delete
test_installer_theme.theme
test_missing_base_theme.theme
views_test_checkboxes_theme.theme

Keep as is for bc and testing
stable9.theme
access_test.theme

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3579903

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicxvan created an issue. See original summary.

nicxvan’s picture

nicxvan commented
Parent issue: » #3554670: [meta] Eliminate core .theme files
sourav_paul’s picture

sourav_paul
Location Kolkata
commented

Working on this...

nicxvan’s picture

nicxvan commented

I am actually going to work on this now.

nicxvan’s picture

nicxvan commented
Issue summary: View changes

nicxvan opened merge request !15142

nicxvan’s picture

nicxvan commented
Issue summary: View changes
nicxvan’s picture

nicxvan commented
Issue summary: View changes
Status: Active » Needs review
nicxvan’s picture

nicxvan commented
Status: Needs review » Needs work

Let's convert the theme-settings.php too.

nicxvan’s picture

nicxvan commented
Title: Eliminate Olivero stable9 and two test .theme files » Eliminate Olivero and three test .theme files
Issue summary: View changes
nicxvan’s picture

nicxvan commented
Status: Needs work » Needs review
Related issues: +#3580152: Deprecate theme-settings.php files

I created #3580152: Deprecate theme-settings.php files for theme settings, let's just do .theme here.

sourav_paul’s picture

sourav_paul
Location Kolkata
commented

Thanks @nicxvan for picking this up, I was actually on it but in the midway, I've to go out for a medical reason. Changes are looks good to me .Feel free to mention me, If anything you want to need to fix or work on.

nicxvan’s picture

nicxvan commented

Sorry about that, it's ready for review if you want to take a look!

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Looks straightforward. the helper function could either be a trait or a some utility class. Per #3579899: Remove remaining claro.theme functions, olivero too is marked as internal, so the underscored function is double-internal and it should be fine to just remove it, no known calls.

catch closed merge request !15142

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 0b415562 on main 
    task: #3579903 Eliminate Olivero and three test .theme files

By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.