Problem/Motivation

This is the same issue of #3564556: JavaScript error when js-cookie library is not loaded
The idea is to fix that on 5.1.x

Steps to reproduce

Please use the same steps of linked issue

Proposed resolution

Apply the same patch / solution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 3579357.patch1.59 KBrenatog
#2 3579357.patch1.66 KBrenatog

Comments

renatog created an issue. See original summary.

renatog’s picture

renatog commented
Status: Active » Needs work
StatusFileSize
new 3579357.patch1.66 KB

This patch as been moved on 6.x

However is necessary to apply the same on 5.x

So marking as Needs Work

renatog’s picture

renatog commented
Related issues: +#3564556: JavaScript error when js-cookie library is not loaded
renatog’s picture

renatog commented
Status: Needs work » Needs review
StatusFileSize
new 3579357.patch1.59 KB

Generated a patch with the same fix

  • f1af5299 committed on 5.1.x 
    feat: #3579357 [5.1.x] JavaScript error when js-cookie library is not...
renatog’s picture

renatog commented
Status: Needs review » Fixed

Moved to the dev branch: 5.1.x

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

renatog’s picture

renatog commented

New version is released with this fix

https://www.drupal.org/project/modal_page/releases/5.1.9

Thanks @istankevych for your fix and also @kenfordesign for lettings us know about 5.1.x version

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.