Problem/Motivation

phpstan reports this deprecation:

 ------ -------------------------------------------------------------- 
  Line   matomo.module                                                 
 ------ -------------------------------------------------------------- 
  292    Call to deprecated method get() of class                      
         Symfony\Component\HttpFoundation\Request:                     
         since Symfony 7.4, use properties `->attributes`, `query` or  
         `request` directly instead                                    
         🪪  method.deprecated                                         
 ------ --------------------------------------------------------------

Steps to reproduce

https://git.drupalcode.org/project/matomo/-/jobs/8324488

Proposed resolution

We should use $request->query->get() instead.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork matomo-3579314

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

prudloff created an issue. See original summary.

prudloff opened merge request !97

prudloff’s picture

prudloff commented
Status: Active » Needs review
kris_nikolov’s picture

kris_nikolov commented
Status: Needs review » Reviewed & tested by the community

Looks good!

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.