Problem/Motivation

#3578053: Remove spurious argument from session_manager service definition fixed an error in core.services.yml where a service had too many arguments; we can add test coverage for this by parsing all services and ensuring the argument count matches the constructor.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3578630

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave opened merge request !15063

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

This isn't really autowiring related but the test is an easy place to insert this check.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Test by reverting #3578053: Remove spurious argument from session_manager service definition, it should fail.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thanks for rerunning that. The media javascript file I'm almost 100% positive a random failure.

I have nothing else to comment.

  • amateescu committed eb04bd5f on 11.x 
    task: #3578630 Check that services definitions match their argument...

  • amateescu committed cf771503 on main 
    task: #3578630 Check that services definitions match their argument...
amateescu’s picture

amateescu commented
Status: Reviewed & tested by the community » Fixed

Tested this manually by adding a random argument to a core service, and it fails as expected.

Committed and pushed cf771503a9c to main and eb04bd5fad7 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

amateescu closed merge request !15063

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.