Problem/Motivation

Fatal error: Type of Drupal\entity_extra_field\Controller\EntityExtraFieldListBuilder::$moduleHandler must not be defined (as in class Drupal\Core\Entity\EntityHandlerBase) in /var/lib/tugboat/src/Controller/EntityExtraFieldListBuilder.php on line 23

when trying to create a new extra field on an entity at e.g. /admin/structure/types/manage/article/extra-fields

in Drupal 11.3.3

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork entity_extra_field-3578461

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue summary: View changes

anybody opened merge request !52

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil
Priority: Normal » Major
Status: Active » Needs review

Please test and review. Can be reproduced in tugboat.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Okay the route is working again in Drupal 11.3.3! I think it should also work for Drupal 10 this way, as the property is then created dynamically?

Maybe we should just create a new 3.x branch soon, after merging the other issues and clean this up?

grevil made their first commit to this issue’s fork.

grevil’s picture

grevil commented

I did some minor adjustments.

grevil’s picture

grevil commented
Assigned: grevil » anybody

The parent class already provides a method "moduleHandler()" which initiates the module handler for us...

What do you think @anybody?

Merge this in 3.x or 2.1.x and live with the potential WSOD when people don't flush their caches?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Also in Drupal 10?

I think 2.1.x would be fine then! Maybe just add an update hook then regarding the container rebuild?

grevil’s picture

grevil commented

D10 https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21... has the same method, so yes.

grevil’s picture

grevil commented
Assigned: anybody » Unassigned
Status: Needs review » Reviewed & tested by the community
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.