Problem/Motivation

This module does not work as is with Firefox - the fallback work is broken.

Steps to reproduce

Install module, configure an animated transition, and attempt to use with Firefox. The page fully reloads, no transition, no animation.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork view_transitions-3578389

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

freelock created an issue. See original summary.

freelock opened merge request !13

freelock’s picture

freelock
Location Seattle
commented
Status: Active » Needs review

Note that when combined with #3558681: Add option to transition only the main content area instead of entire body, the same line is getting changed. The end result should favor the document.body.classList instead of evt.detail.target.classList .

This fixes the fallback support for Firefox -- without it, Firefox does full page reloads with no animations. With it, animations work, and the page content gets reloaded without a page refresh.

brianperry’s picture

brianperry
he/him
commented
Status: Needs review » Needs work

Changes look reasonable here, but as you suspected @freelock, there is a merge conflict on the MR that needs to be resolved.

freelock’s picture

freelock
Location Seattle
commented
Status: Needs work » Needs review

Ok! Rebased on the new HEAD of 1.0.x, should be good to go!

  • freelock committed 9886996c on 1.0.x 
    feat: #3578389 Firefox fallback support is broken
brianperry’s picture

brianperry
he/him
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.