Problem/Motivation

The €-sign U+20AC is translaterated as EU, but it should be EUR. EU is European Union, EUR is EURO.

Proposed resolution

Change the transliteration to EUR

Issue fork drupal-3578289

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joshahubbers created an issue. See original summary.

joshahubbers opened merge request !15044

joshahubbers’s picture

joshahubbers commented
Status: Active » Needs review
ghost of drupal past’s picture

ghost of drupal past
he/him
commented
Status: Needs review » Reviewed & tested by the community

The fix is correct for the issue. Likely more could be done: where did this curious error came from? The contrib transliteration project which became core in 2012 mainly -- but not solely -- used the tables from the Perl Text::Unidecode project. And indeed, one can see the EU in https://metacpan.org/release/SBURKE/Text-Unidecode-0.04/source/lib/Text/... The Perl project didn't see a release after 2001 until 2014 but in 2012 the tables got into Drupal core. This error got fixed in a 2013 change: https://metacpan.org/release/SBURKE/Text-Unidecode-1.01/source/lib/Text/.... I see a few other tables have later than 2001 dates as well, the differences should be produced somehow and integrated as needed. As noted, the tables Drupal used even in 2012 had multiple sources and those sources were tweaked in contrib before and core after so the current data set is completely unique so this is not a trivial endeavour but as this very issue shows it'd be worth trying. https://github.com/uperl/App-cpangitify is probably helpful here.

nicxvan’s picture

nicxvan commented
Title: Tansliteration of € is EU, but should be EUR » Transliteration of € is EU, but should be EUR

sivaji_ganesh_jojodae made their first commit to this issue’s fork.

quietone’s picture

quietone commented
Assigned: Unassigned » quietone

@ghost of drupal past, thanks for the research.

I should get to this within 24 hours.

  • quietone committed 31a27aad on main 
    fix: #3578289 Transliteration of € is EU, but should be EUR

By:...

  • quietone committed a3c7795f on 11.x 
    fix: #3578289 Transliteration of € is EU, but should be EUR

By:...

  • quietone committed 47fb5a6a on 11.3.x 
    fix: #3578289 Transliteration of € is EU, but should be EUR

By:...
quietone’s picture

quietone commented
Version: main » 11.3.x-dev
Assigned: quietone » Unassigned
Status: Reviewed & tested by the community » Fixed

I too did research yesterday to confirm that EUR is correct. For example, https://ec.europa.eu/economy_finance/events/2009/theeuro/isola3_en2008-2...

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone closed merge request !15044

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.