Problem/Motivation

Tiny follow-up from #3577376: Remove recently introduced deprecations from SessionManager. I forgot to adapt the arguments array of the session_manager service definition.

Steps to reproduce

Proposed resolution

Drop the last item from the arguments of session_manager service definition.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3578053

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

znerol created an issue. See original summary.

znerol changed the visibility of the branch 3578053-remove-spurious-argument to hidden.

znerol changed the visibility of the branch 3578053-remove-spurious-argument to active.

znerol changed the visibility of the branch 3578053-remove-spurious-argument to hidden.

znerol changed the visibility of the branch 3578053-remove-spurious-argument to active.

znerol opened merge request !15032

znerol’s picture

znerol commented
Status: Active » Needs review
dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

I thought about tagging this as "Novice" for the code review, but I'm not sure there's anything to be learned from checking this one-line change.

For the sake of being thorough I compared the service definition to the class constructor, just to make certain something else wasn't missed. I didn't see any issue. I also searched Core for any manual instantiations of SessionManager to make certain that they'd been updated. But there aren't any. LGTM.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Maybe similar to #3578486: Check aliases match interfaces in AutowireTest we could add test coverage for this, using reflection to check that the arguments match the services.

Committed and pushed 53c41808f94 to main. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

longwave closed merge request !15032

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Opened #3578630: Check that services definitions match their argument count

  • longwave committed 53c41808 on main 
    fix: #3578053 Remove spurious argument from session_manager service...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.