Problem/Motivation

The last successful pipeline from the 3.x branch is from 7 months ago - https://git.drupalcode.org/project/openid_connect/-/pipelines/566412

Latest changes appear to introduce several failures - https://git.drupalcode.org/project/openid_connect/-/pipelines/759138

Steps to reproduce

n/a

Proposed resolution

Fix the tests so we can be sure additional changes are not breaking functionality. Testing more regularly would have given insight for when failures introduced.

Remaining tasks

  • Fix tests
  • Maintainers setup scheduled pipeline in gitlab for regular testing

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Issue fork openid_connect-3577851

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ericgsmith created an issue. See original summary.

ericgsmith opened merge request !194

ericgsmith’s picture

ericgsmith commented
Status: Active » Needs review

Updated tests with the additional / missing service args - unfortunately not enough, now failing with different errors. Setting to needs work.

ericgsmith’s picture

ericgsmith commented
Status: Needs review » Needs work

Oops - incorrect status

ericgsmith’s picture

ericgsmith commented

MR is now down to 1 error and 1 failure. Failure is related to changes in image handling, and I have not debugged the serialisation error from the update hook.

Not actively looking at this.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Priority: Normal » Major

This feels like enabling to all other work on this module so bumping to "Major". It might be "critical".

pfrilling’s picture

pfrilling
Location Minster, OH
commented
Assigned: Unassigned » pfrilling

Thanks @ericgsmith. I had withheld the original test when alpha7 released per the security guidelines regarding automated tests. It's been nearly two weeks now. I'll get the new test added and clean up the pipeline.

pfrilling’s picture

pfrilling
Location Minster, OH
commented
Assigned: pfrilling » Unassigned
Status: Needs work » Needs review

Fixed the tests and confirmed the pipeline is now green 🎉.

I decided to disable the testing of the next major. We can reinstate that once this is stable.

pfrilling’s picture

pfrilling
Location Minster, OH
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.