There are some phpcs errors in the 2.0.x branch. Resolve them.

Issue fork scanner-3577756

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

damienmckenna created an issue. See original summary.

velmir_taky made their first commit to this issue’s fork.

velmir_taky opened merge request !50

velmir_taky’s picture

velmir_taky commented
Status: Active » Needs review

Added phpcs.xml.dist to exclude JS files from phpcs checks. All 44 errors were false positives — PHP-specific sniffs (Generic.PHP.UpperCaseConstant, Squiz.WhiteSpace.OperatorSpacing) applied to JavaScript. This is the same approach Drupal core uses in core/phpcs.xml.dist.

paraderojether’s picture

paraderojether commented
Status: Needs review » Reviewed & tested by the community

Hi

Hi

I reviewed MR!50, and confirmed PHPCS is now passed on Gitlab CI.

Moving this to RBTC!
Thank you.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Thank you both.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.