Problem/Motivation

Follow-up to #3577234: Functional tests very slow on gitlab to fine tune things a bit more.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3577377

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch opened merge request !15005

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

This is about as far as I can get it without more surgery:

BigPipeRegressionTest was the single slowest tests so consolidated methods a bit more.

Added #slow to a handful of slow tests that were showing running over the end of jobs but weren't previously marked. Couple of new ones like ckeditor5 linking, couple of other ones that mostly got unlucky with test ordering and weren't noticed before when they might have naturally started earlier.

Re-ordered the jobs slightly so they run slowest first (e.g. get any available runners, then the quicker jobs can wait).

Tweaked concurrency a bit to what appears to be a decent balance between enough tests at a time vs. potentially overloading the runners and making everything grind to a halt. But as we proved in the previous issue, natural variation in test runs makes this an extremely inexact science and it's mostly guesswork. The new output @longwave added helps a lot though.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +run-tests.sh
Related issues: +#3538002: run-tests.sh - separate test allocation to bins into a WorkAllocator class, +#3536964: run-tests.sh - segregate command line parsing and use Symfony Console classes, +#3526459: [PP-1] Autodetect available CPUs in run-tests.sh for concurrency, +#3040694: Use previous PHPUnit JUnit results to pack tests in bins when parallelizing

LGTM. Added related issues that could help.

longwave made their first commit to this issue’s fork.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Title: Pipeline performance pfollowups » Pipeline performance followups
catch’s picture

catch
he/him
Primary language English
commented
Issue tags: +Test suite performance
Related issues: +#3577785: Use the minimal install profile in package_manager tests

Did some extra experimentation here and reverted it - state is the same as before the RTBC now. Moved that over to #3577785: Use the minimal install profile in package_manager tests which also has an MR now.

edit: and also #3577840: Consolidate test methods in GenerateThemeTest

  • longwave committed 8a21edc8 on main 
    test: #3577377 Pipeline performance followups

By: catch
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed 8a21edc and pushed to main. Thanks!

Doesn't backport cleanly, I think at this point it's not worth it anyway.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

longwave closed merge request !15005

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.