Problem/Motivation

We inverted the service identifier in EditorController

$this->editorElement = \Drupal::service('editor.element')
$this->editorElement = \Drupal::service('element.edit')

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3577279

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicxvan created an issue. See original summary.

nicxvan changed the visibility of the branch 3577279-fix-service-call to hidden.

nicxvan opened merge request !14998

nicxvan’s picture

nicxvan commented
Status: Active » Needs review

I can't rerun that failed test, but I think it's random.

Someone reviewing this please rerun that.

nicxvan’s picture

nicxvan commented
Issue summary: View changes
nicxvan’s picture

nicxvan commented
Issue summary: View changes
nicxvan’s picture

nicxvan commented
Issue summary: View changes
Issue tags: +12.0.0 beta blocker
nicxvan’s picture

nicxvan commented
Issue tags: -12.0.0 beta blocker

Didn't mean to add the tag.

godotislate’s picture

godotislate
he/him
commented
Status: Needs review » Reviewed & tested by the community

lgtm

  • catch committed a68fc4c4 on main 
    fix: #3577279 Fix service call in EditorController xss bc layer

By:...

catch closed merge request !14998

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.