Problem/Motivation

Functional tests on main are running around three times as slow as they previously used to on gitlab.

This is because when we used a child pipeline, the concurrency overrides did not work and everything got 24 concurrency. Hardware differences and other random events like busy runners convinced us that concurrency tweaks were impacting things.

Function JS tests were somewhat limited but because of the selenium limit, not concurrency.

Steps to reproduce

Proposed resolution

Increase concurrency closer to where it actually was for functional tests (24) and a little bit for functional js tests. Also add some concurrency and debug output to run-tests.sh so we don't get fooled again.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3577234

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch opened merge request !14996

catch opened merge request !15000

longwave made their first commit to this issue’s fork.

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes
Status: Active » Reviewed & tested by the community

Have been discussing this and trying things out with @longwave and we tracked it down to the change to a recursive pipeline instead of child pipelines, but in the silliest possible way that this change made concurrency overrides work where they previously were ignored.

Going to commit from needs review here because it's only gitlab yaml changes and a minimalist change to phpunit to prevent this happening again. We can tweak some of these numbers in follow-ups.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main. What a relief. While I worked together with this on @longwave all the meaningful code changes are his, and this is holding up every other issue in core with slow pipelines at the moment.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14996

  • catch committed b7a8ea8b on main 
    fix: #3577234 Functional tests very slow on gitlab

By: catch
By:...

catch closed merge request !15000

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.