Motivation

For canvas routes we want to render the editorial preview the LupusCSR theme, so we have a proper preview with header/footer.

Lupus-CSR changes things for the recently added "Lupus Decoupled" theme switching support, this needs to be re-considered.
The theme switching support is a bit confusing when we have both Lupus CSR and again different themes. Moreover, forms rendered in canvas pages or layout-builder pages won't get the overridden theme, so the feature is flawed and should be reverted.

Proposed resolution

- Improve custom_elements Nuxt preview-provider to re-use existing nuxt-app from CSR
- Allow custom elements preview providers to declare Lupus-CSR support, providing the replacements.
- Make LupusCSR configurable - Default to CSR using the frontend-server. Optionally, allow "Custom" config with a form for the metadata or with the preview-provider.
- Make the setting about theme switching canvas only
- Revert / undo theme switching for form routes

Issue fork lupus_decoupled-3577107

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fago created an issue. See original summary.

fago’s picture

fago
Primary language German
Location Vienna
commented
Title: Allow rendering canvas routes with lupus-csr themes » Revert addition of theme overrides for form routes
Issue summary: View changes

Thinking more about this, we cannot easily do this. We'd have to merge the canvas scripts into whatever SPA is in the frontend. We clearly don'T want to go there, since this is never a robust solution.

So instead, we accept that canvas routes need to work differently - with a regular Drupal theme like Stark. Maybe it's even not too bad, since the user won't see header/footer that is not editable in canvas anyway. If people want edit header/footer regions, a custom theme would have to be provided for that, which provides those regions + the nuxt-app/ce-api would have to integrate that. then this would again work with both CSR and preview rendering. Summing up, this seems to be the better approach.

So what remains todo here is un-doing the support for route-based theme-overrides for form rendering, since this won't work reliably with varying frontend themes in canvas and CSR. If we need to adjust form-templates, a module doing that generally seems to better situated.

fago’s picture

fago
Primary language German
Location Vienna
commented
Issue summary: View changes
fago’s picture

fago
Primary language German
Location Vienna
commented
Title: Revert addition of theme overrides for form routes » Remove theme overrides for form routes, make them canvas only

fago opened merge request !152

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Active » Fixed

Implemented and merged.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • fago committed 98391fea on 1.x 
    fix: #3577107 Remove theme overrides for form routes, make them canvas...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.