Follow-up from #3576767: Update composer requirement for nicebooks/isbn

Problem/Motivation

nicebooks/isbn has introduced some breaking changes. For details, see https://github.com/nicebooks-com/isbn/releases/tag/0.7.0.

We should try to resolve the deprecations, but at the same time see if it is possible to keep compatibility with older versions. Because recent versions of nicebooks/isbn require PHP 8.2 and since at the moment we support older releases of Drupal Core we might want to keep support for PHP 8.1 as well.

If that is not easy to do, we need to bump the requirement of nicebooks/isbn:

"require": {
    "nicebooks/isbn": "^0.6 || ^0.7"
}

That does mean the module would be no longer compatible with PHP 8.1.x and older.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork isbn-3576931

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

megachriz created an issue. See original summary.

megachriz’s picture

megachriz
Primary language Dutch
commented
Related issues: +#3576767: Update composer requirement for nicebooks/isbn

megachriz opened merge request !18

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Active » Fixed

All tests pass on nicebooks/isbn version 0.5 till 0.8! I scheduled the merge.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • megachriz committed a11d6acd on 8.x-1.x 
    task: #3576931 Added support for nicebooks/isbn 0.7 and 0.8.

By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.