Problem/Motivation

Track the steps needed to deprecate extension Settings Tray from core to contrib. See Remove a core extension and move it to a contributed project of the deprecation policy.

The removal of Settings Tray was approved in #3576315: [policy, no patch] Move Settings Tray to a contributed project.

Remaining tasks

  1. Create a section on Deprecated and obsolete modules and themes to provide recommendations for sites using extension Settings Tray. The recommendations are to include instructions for sites using the extension and for contributed projects that depend on then extension.
  2. Add the following to the extension info.yml file

    3. lifecycle: deprecated
    lifecycle_link: https://www.drupal.org/node/3223395#s-settings-tray

  3. Add #[IgnoreDeprecations] to all tests in the extension.
  4. Add a change record and include a link the the doc page.
  5. Deprecate any library that is only used by the extension.
  6. Do a thorough search of core for any remaining references to the extension. If references are found, outside of the extension, then creates issues to remove the references.

Release notes snippet

Issue fork drupal-3576669

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !15016

quietone’s picture

quietone commented
Status: Postponed » Needs review
smustgrave’s picture

smustgrave commented
Issue tags: +Needs change record, +Needs documentation updates

Based on how we did telephone assuming a CR is needed here.

Tagged for documentation update as just a reminder to update https://www.drupal.org/node/3223395

quietone’s picture

quietone commented
Issue tags: +11.5.0 release priority

Change record added

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs change record

Did this with brute force searching lol

Deleted the module and in phpstorm did a search for settings_tray and settings tray. Only instances were in phpstan-baseline, ignore-deprecations, and MAINTAINERS.

Another bites the dust!

nicxvan’s picture

nicxvan commented

I also just pushed up a test branch where I just deleted the module, then I deleted the phpstan references and set phpstan to allow_failure so I could get past it.

https://git.drupalcode.org/project/drupal/-/pipelines/920875

It looks mostly green the only failure is a nightwatch failure but I can't rerun, I think it's random.

Seems like a good way to check.

  • catch committed d7192900 on main 
    task: #3576669 Deprecate Settings Tray module

By: quietone
By:...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to main, thanks!

This needs a backport MR for 11.x

quietone opened merge request !16712

quietone’s picture

quietone commented
Status: Patch (to be ported) » Needs review

There was a conflict in SettingsTrayBlockFormTest.php.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems like a good backport.

  • catch committed 46f947f9 on 11.x 
    task: #3576669 Deprecate Settings Tray module

By: quietone
By:...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone’s picture

quietone commented

Published the change record

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Removed exactly one day before its tenth birthday! 🎂

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.