Problem/Motivation

This is a follow-up to #3576172: Allow "/" as delimiter for view display arguments to synchronize with the views preview. Where we introduced support to devide view display arguments via /.

The problem with this is, when inside the view contextual filter:

Allow multiple arguments divided by "," or "+"

is set, the old argument seperation inside entity extra field (dividing by ",") clashs with this notation.

Steps to reproduce

Proposed resolution

  • Remove support for dividing view display arguments by ",".
  • Create an update hook to update old notations using "," to the new "/" notation.
  • Verify whether we need any other processing to allow "+" (AND) and "," (OR).

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork entity_extra_field-3576486

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

grevil created an issue. See original summary.

nickolaj made their first commit to this issue’s fork.

nickolaj opened merge request !50

nickolaj’s picture

nickolaj
Primary language Ukrainian
commented
Status: Active » Needs review

Patch removes "," as a view display argument delimiter (now only "/" is used), updates the form description to mention "+" and "," as views multiple argument notation, and adds update hook 9202 to convert existing configs from "," to "/" delimiter.

anybody made their first commit to this issue’s fork.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work
Issue tags: +Needs manual testing

Thanks @nickolaj I left some final comments and improved + unified the description using the same text as the Views UI does.

Would you like to take the final steps?
Please also test that + and , work as expected for multiple arguments.

If possible it would of course be best to have tests, but I guess that will be hard...

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Related issues: +#3408058: Handling Multiple Token Values in View Arguments

I think this is very much related and should also be solved then: #3408058: Handling Multiple Token Values in View Arguments

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil
grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs manual testing

Alright adjusted accordingly. I am using referenced taxonomies now, which makes more sense in this context.

"argumentsAnd" doesn't make too much sense here, since node id 1 AND node id 2 doesn't make much sense, so we could only do:

'arguments' => '1/1,2',

But that test wouldn't be very meaningful.

Please review!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

We need to remove the array_filter() because it should exactly behave like in Views UI and empty arguments are allowed!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

GREAT!!

  • anybody committed 416db63f on 2.1.x authored by nickolaj 
    Issue #3576486: Patch removes "," as a view display argument delim...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.