Problem/Motivation

There is a key
experimental: true
That is not correct
It should be lifecycle: experimental

Steps to reproduce

Enable the theme

Proposed resolution

Remove experimental: true
Add lifecycle: experimental

Remaining tasks

Should we mark it as hidden as well?

User interface changes

before:
the card for the admin theme on the appearance page

after:
the card for the admin theme on the appearance page

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#10 before.jpg54.7 KBrkoller
#10 after.jpg59.27 KBrkoller

Issue fork drupal-3576431

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicxvan created an issue. See original summary.

nicxvan’s picture

nicxvan commented
Priority: Normal » Major
Issue summary: View changes

nicxvan opened merge request !14956

nicxvan changed the visibility of the branch 3576431-mark-new-admin to hidden.

nicxvan’s picture

nicxvan commented
Issue summary: View changes
nicxvan’s picture

nicxvan commented
Issue summary: View changes

Crediting kentr for identifying this issue.

nicxvan’s picture

nicxvan commented
Status: Active » Needs review
catch’s picture

catch
he/him
Primary language English
commented
Priority: Major » Critical
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs review » Reviewed & tested by the community

Change is obvious

rkoller’s picture

rkoller
he/him
Primary language German
Location Nürnberg, Germany
commented
Issue summary: View changes
StatusFileSize
new after.jpg59.27 KB
new before.jpg54.7 KB

added before and after screenshots to illustrate the change. the MR is fixing the problem in the short term thanks for that. but in regard of readability that card heading is really hard to process. It would be good if issue around #2860419: [Meta] Appearance page is too long and confusing could get moving again. one of its child issues would for example move the experimental label from the heading to chips #3249374: Redesign the cards for the Appearance page

  • longwave committed 1b42b613 on main 
    fix: #3576431 Mark new admin theme as experimental

By: nicxvan
By:...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to main. I assumed admin theme would land in 11.x as well but it's not there, waiting for clarification from @lauriiii on that.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed 91b003d5 on 11.x 
    fix: #3576431 Mark new admin theme as experimental

By: nicxvan
By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.