Problem/Motivation

This issue was discovered in #3576043: Delete zombie test modules. @nicxvan noted that the hook_collector_hook_attribute test module should still be relevant at which point we discovered that the test that uses it, HookCollectorPassTest::testHookAttribute(), had been deleted.

Proposed resolution

Restore the HookCollectorPassTest::testHookAttribute() test. Get the test code from the commit where it was deleted.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3576260

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dcam created an issue. See original summary.

dcam’s picture

dcam commented
Issue summary: View changes
dcam’s picture

dcam commented
Issue summary: View changes
Issue tags: +Novice
scontzen’s picture

scontzen commented
Assigned: Unassigned » scontzen

scontzen opened merge request !14945

scontzen’s picture

scontzen commented
Assigned: scontzen » Unassigned
Status: Active » Needs review

Restored testHookAttribute() in its original position (after testProceduralHooksSkippedWhenConfigured(), before testHookFirst()). The method was accidentally removed in commit 308ad15 (#3495943). Test passes locally.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems pretty straight forward adding the test back. Thanks @scontzen

nicxvan’s picture

nicxvan commented
Component: system.module » extension system

Thanks guys! Moving to extension since it's related to the hook attribute.

  • catch committed 8f0f9549 on 11.x 
    task: #3576260 Restore HookCollectorPassTest::testHookAttribute()

By:...

  • catch committed dfa8a4e3 on main 
    task: #3576260 Restore HookCollectorPassTest::testHookAttribute()

By:...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Good spot. Committed/pushed to main and 11.x, thanks! Good job it still passes..

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14945

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.