Problem/Motivation

When loading multiple entities, there are a lot of calls to FieldDefinition->getColumns() and DefaultTableMapping::getColumns(). We can move those into their own foreach loop.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3576129

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

catch opened merge request !14936

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

not sure how to review this one outside the eye test. From what I can tell you did one call, stored into an array, and used that variable. In that case LGTM.

sivaji_ganesh_jojodae made their first commit to this issue’s fork.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

Rebased the source branch was 139 commits behind the target branch.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

@sivaji_ganesh_jojodae please do not unnecessarily rebase MRs, this is only useful if there are merge conflicts - otherwise it is just adding noise to the issue queue and using up CI time (and money) to rerun pipelines.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 6a691af821b to main and fb3aa03d0ea to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed fb3aa03d on 11.x 
    perf: #3576129 Reduce calls to FieldDefinition::getColumns()

By: catch...

  • alexpott committed 6a691af8 on main 
    perf: #3576129 Reduce calls to FieldDefinition::getColumns()

By: catch...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.