Problem/Motivation

The commerce 3.3 release recommends upgrading commerce_shipping to version 3. This module requires commerce_shipping 2 in its composer.json file and thus blocks the upgrade to commerce_shipping 3.

Steps to reproduce

  1. Have this module installed.
  2. composer require 'drupal/commerce_shipping:^3.0'
  3. Watch composer give you an error.

Proposed resolution

Change the module's composer.json to require "drupal/commerce_shipping": "^2 || ^3".

Remaining tasks

  • Update the module's composer.json file
  • Test and review the change
  • Tag a new release

User interface changes

None

API changes

None

Data model changes

None

Issue fork commerce_shipping_product_exclude-3575932

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

reinimax created an issue. See original summary.

anybody made their first commit to this issue’s fork.

anybody opened merge request !5

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Needs review

Here we go, please test if it works!

reinimax’s picture

reinimax commented

Thanks for the fast reply! I tested the issue fork on our site both before and after the upgrade to commerce_shipping 3 and it works fine.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

As of #5

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.