Problem/Motivation

Part of deprecating Toolbar.

Steps to reproduce

Proposed resolution

Deprecate and move Settings Tray to contrib first.

Just remove Toolbar or replace it with something?

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3575909

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !14923

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

There is a bunch more delicate unpicking to be done here, there are multiple references to toolbar in settings_tray that need to be moved out.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Hm, settings_tray depends on contextual which in turn depends on toolbar.. seems we need to make both settings_tray and contextual also work with navigation before we can disentangle this from toolbar.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I've just tried out Settings Tray on an Umami install; it seems to do not really work at all while Navigation is installed, whether Toolbar is installed or not. I had to install Toolbar and uninstall Navigation before the "Quick edit" contextual links worked properly for me.

There doesn't seem to be an issue for this but some brief discussion in #3421969-81: [PLAN] New Navigation and Top Bar to replace Toolbar Roadmap: Path to Stable, Gabor then raised this over at #3484850-4: [meta] Tasks to deprecate Toolbar module but there has been no followup.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs work
catch’s picture

catch
he/him
Primary language English
commented
Related issues: +#3576315: [policy, no patch] Move Settings Tray to a contributed project

Assuming we do #3576315: [policy, no patch] Move Settings Tray to a contributed project first this will become a non-issue - contrib settings tray can depend on contrib toolbar.

quietone’s picture

quietone commented
Issue summary: View changes
Status: Needs work » Postponed

Then this is likely a won't fix. But, for now, changing to Postponed in case something else mean this needs to be done.

I commented about this in the issue summary of the parent

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Postponed » Closed (won't fix)

Nothing came up in the 4 months inbetween and settings tray is on the verge of bring removed also, so moving to won't fix for good :)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.