Problem/Motivation

Coming from #3482261-20: Add text field to paste filters for documentation.

Our current tests rely on the behaviour of node module creating a body field automatically, which is no longer the case with Drupal core 11.3+.

Steps to reproduce

Run tests on Drupal 11.3 or higher.

Proposed resolution

Switch to a specifically named body field such as field_body to not rely on core's body field and have tests work on Drupal 10 and Drupal 11.

Remaining tasks

  • Update config in ckeditor5_paste_filter_test module
  • Run tests against Drupal 10 (gitlab-ci-local "playwright (previous major)")
  • Run tests against Drupal 11 (gitlab-ci-local playwright)

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Issue fork ckeditor5_paste_filter-3575837

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

star-szr created an issue. See original summary.

nickolaj made their first commit to this issue’s fork.

nickolaj opened merge request !19

nickolaj’s picture

nickolaj
Primary language Ukrainian
commented
Status: Active » Needs review

Replaced the test module's reliance on core's `body` field (field.storage.node.body) with a custom `field_body` field, including its own field storage config. This ensures compatibility with Drupal 11.3+ where the node module no longer automatically creates the body field storage.

star-szr’s picture

star-szr
he/him
Primary language English
commented

Thank you very much @nickolaj! I think some other problem is happening with the tests since the `1.1.x` branch is failing in the same way. I will look into this and can rebase your branch at which point I think this would be green.

Edit: Actually, making the change in this branch might make the most sense since if I update 1.1.x it will just fail straight away.

  • star-szr committed d7521c0f on 1.1.x authored by nickolaj 
    test: #3575837 Use custom body field instead of core's `body` field
star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs review » Fixed

Merged with the additional change to update the Docker image for CI.

Many thanks, @nickolaj!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.