Problem/Motivation

The module is not yet compatible with jQuery 4. This results in errors and a broken countUp formatter.

Uncaught TypeError: $.isNumeric is not a function
    at Object.countup (countup.js?v=1.x:78:15)
    at countup.js?v=1.x:42:17
    at Array.forEach (<anonymous>)
    at IntersectionObserver.root (countup.js?v=1.x:38:19)

Proposed resolution

Replace deprecated functions that were removed in jQuery 4.

Issue fork countup_formatter-3575670

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

guido_s created an issue. See original summary.

guido_s opened merge request !7

scontzen’s picture

scontzen commented
Status: Active » Reviewed & tested by the community

Looks good! Clean refactoring that addresses jQuery 4 compatibility and improves the architecture at the same time.
- core/jquery.once → core/once with proper context usage
- $.isNumeric() replaced with native JS validation
- Scroll/resize event listeners replaced with IntersectionObserver – more efficient and also resolves the event listener rebinding from #3575127

guido_s’s picture

guido_s
Location Cologne
commented
Related issues: +#3575127: Event listeners re-bound on every attach due to incorrect jQuery wrapper around once().length

  • guido_s committed f16eff10 on 1.0.x 
    feat: #3575670 Provide compatibility with jQuery 4

By: guido_s
By:...
guido_s’s picture

guido_s
Location Cologne
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.