Problem/Motivation

The module provides an option to display forms, but the icon is missing.

Steps to reproduce

  • Install module
  • Enable the forms at admin/config/user-interface/navigation/extra
  • See the icon is missing

Proposed resolution

Add icon.

Remaining tasks

Create and review MR.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 forms.png7.37 KBtim-diels

Issue fork navigation_extra-3575562

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tim-diels created an issue. See original summary.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
StatusFileSize
new forms.png7.37 KB

Maybe this icon?

Forms

SVG code => https://sharetext.io/kffxe2cx

dtfabio’s picture

dtfabio commented
Assigned: Unassigned » dtfabio

Dag Tim,

I will try to implement this.

Greetings,

Fabio

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Assigned: dtfabio » tim-diels

Sorry for interrupting the work, but I have time and will pick it up now.

tim-diels opened merge request !29

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Assigned: tim-diels » Unassigned
Status: Active » Needs review

I've used https://icons.getbootstrap.com/icons/inboxes/ instead of the @ symbol.

dtfabio’s picture

dtfabio commented
Assigned: Unassigned » dtfabio
dtfabio’s picture

dtfabio commented
Assigned: dtfabio » Unassigned

Hi Tim,

I have tested the change on four different instances.

Drupal core versions: 10.3.14, 10.6.3, 11.2.10 and 11.3.3
PHP versions: 8.3.30 (10.3 and 11.2.10) and 8.4.18 for the other core versions.
Database version: MariaDB 11.8.6 and MySQL 8.4.5

I noticed that for the D10.x versions there was no fallback if the icon API was unavailable, so I added this to the code and optimised the SVG file.

Now I can see the icon correctly on all instances. Please let me know if this is also the case for you. Then this ticket can be moved to RTBC.

Greetings,

Fabio

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Tested and works great on both D10 and D11.

  • tim-diels committed 29947441 on 1.0.x 
    fix: #3575562 Missing forms icon

By: tim-diels
By: dtfabio
tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.