Problem/Motivation

The schema.yml is missing some items:

  • plugins.blocks.position
  • plugins.blocks.navigation_safe_block_ids
  • plugins.blocks.hidden_navigation_safe_block_ids
  • plugins.tools
  • plugins.common.generate_overview_links
  • plugins.forms
  • plugins.users.roles_to_hide
  • plugins.local_tasks
  • plugins.version
  • plugins.content.recent_items.hide_empty_list

Steps to reproduce

  • Install the module.
  • Install the config inspector module
  • Go to admin/reports/config-inspector/navigation_extra.settings/list and see the errors.

Proposed resolution

Add missing items

Remaining tasks

Create and review MR

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#6 config-inspector-navigation-extra-settings-list.png1.1 MBdtfabio

Issue fork navigation_extra-3575538

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tim-diels created an issue. See original summary.

nickolaj made their first commit to this issue’s fork.

nickolaj opened merge request !27

nickolaj’s picture

nickolaj
Primary language Ukrainian
commented
Status: Active » Needs review

Added missing schema definitions for all 10 reported config keys: blocks (position, navigation_safe_block_ids, hidden_navigation_safe_block_ids), common (generate_overview_links), content recent_items (hide_empty_list), users (roles_to_hide replacing incorrect roles_to_show), and full plugin schemas for tools, forms, local_tasks, and version. Also fixed a typo (`lable` -> `label`) in override_max_menu_depth.

dtfabio’s picture

dtfabio commented
Assigned: Unassigned » dtfabio
dtfabio’s picture

dtfabio commented
Assigned: dtfabio » Unassigned
Status: Needs review » Needs work
StatusFileSize
new config-inspector-navigation-extra-settings-list.png1.1 MB

Hi nickolaj,

I have tested the change on four different instances.

Drupal core versions: 10.3.14, 10.6.3, 11.2.10 and 11.3.3
PHP versions: 8.3.30 (10.3 and 11.2.10) and 8.4.18 for the other core versions.
Database version: MariaDB 11.8.6 and MySQL 8.4.5

After applying the patch, I still received errors on all instances because the configuration schema did not match the existing configuration.

Errors on config that is not the samen type as the declared schema.

I think it would be a good idea to write an update hook to set the configuration correctly for sites that are already using the module, which will also help to avoid unexpected behaviour.

Greetings,

Fabio

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Assigned: Unassigned » tim-diels

I'll have a look at this.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Assigned: tim-diels » Unassigned
Status: Needs work » Needs review

Adjusted one more data type and added update hook.

dtfabio’s picture

dtfabio commented
Assigned: Unassigned » dtfabio
dtfabio’s picture

dtfabio commented
Assigned: dtfabio » Unassigned
Status: Needs review » Reviewed & tested by the community

Hi Tim,

Re- tested the change on the same four instances.

Drupal core versions: 10.3.14, 10.6.3, 11.2.10 and 11.3.3
PHP versions: 8.3.30 (10.3 and 11.2.10) and 8.4.18 for the other core versions.
Database version: MariaDB 11.8.6 and MySQL 8.4.5

After the update, all configuration errors have disappeared, so I think this ticket can be marked as RTBC.

Greetings,

Fabio

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.