Problem/Motivation

Show machine name and description in "Manage extra fields" table (in the tab), e.g. /admin/structure/types/manage/XXXXXX/extra-fields

This is useful to see details early and if you're using the machine name in code then.

The machine name could be displayed <small> below the title and the description as last column before the actions.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 Before patch.png35.49 KBanjuelsaphilip2020
#9 After patch.png43.09 KBanjuelsaphilip2020

Issue fork entity_extra_field-3575514

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

aayushpathak made their first commit to this issue’s fork.

aayushpathak’s picture

aayushpathak commented

working on it !

aayushpathak opened merge request !42

aayushpathak’s picture

aayushpathak commented
Assigned: grevil » Unassigned
Status: Active » Needs review

anybody changed the visibility of the branch 3575514-show-machine-name to hidden.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Unrelated fixes are okay to me in this case, thanks. Detailed review and test to be done.

grevil’s picture

grevil commented
Status: Needs review » Needs work

Unrelated fixes are okay to me in this case

Not if they completely whipe unrelated function documentation and rename random variables.

anjuelsaphilip2020’s picture

anjuelsaphilip2020 commented
StatusFileSize
new After patch.png43.09 KB
new Before patch.png35.49 KB

Hi, I’ve verified and tested MR !42 and successfully applied the patch on version 2.1.x-dev.The changes are working as expected.
Following steps I followed:

  1. Go to Structure → Content types → Article → Manage extra fields.
  2. Create a new extra field.
  3. Save the extra field.
  4. Observe the Manage extra fields table

Testing Result:
After applying the patch, the Manage extra fields table now displays the machine name below the field label and the description in its own dedicated column.
Attaching screenshots for reference.
Thanks

aayushpathak’s picture

aayushpathak commented
Status: Needs work » Needs review

Updated the MR to include only the required changes.
The machine name is now displayed below the label and the description is added as a dedicated column before operations.

anybody closed merge request !42

anybody reopened merge request !42

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil

@grevil After fixing the blocker #3578461: Fatal error: Type of Drupal\entity_extra_field\Controller\EntityExtraFieldListBuilder::$moduleHandler must not be defined (as in class Drupal\Core\Entity\EntityHandlerBase) in /var/lib/tugboat/src/Controller/EntityExtraFieldListBuilder.php on line 23 please review this and merge if fine.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Update: Let's do it like in /admin/structure/types/manage/page/display and place the machine name into a dedicated (second) column "Machine name" instead of the combined field.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: grevil » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • anybody committed 34005e72 on 2.1.x 
    feat: #3575514:Show machine name and description - moved "Display Type"...
aayushpathak’s picture

aayushpathak commented

Hi,

I noticed the issue has been marked as fixed. Could we please add and distribute the contribution credits for this issue?

Thanks!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks @aayushpathak this was indeed forgotten entirely (by me) ;) Sorry, thanks for the reminder!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.