Problem/Motivation

@thomas.frobieter and me several times selected a disabled view display.

Please add a disabled attribute to the selects for disabled

  • views
  • view displays

(and maybe other references that work like this in the module). Plus a " (disabled)" suffix.

Only if it's easy. Otherwise we should discuss sorting them out entirely, but that's less clear, why missing then...

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#10 screenshot-2026-02-27 11_37_55.png8.62 KBgrevil

Issue fork entity_extra_field-3575505

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

aayushpathak made their first commit to this issue’s fork.

aayushpathak’s picture

aayushpathak commented

working on it !

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: grevil » Unassigned

aayushpathak opened merge request !45

aayushpathak’s picture

aayushpathak commented
Status: Active » Needs review
grevil’s picture

grevil commented
Assigned: Unassigned » grevil
Status: Needs review » Needs work

No, sorry, the MR contains an enormous amount of unrelated changes and the fix is, let's say "uncared for".

I'll provide a seperate MR with a fix.

grevil closed merge request !45

grevil changed the visibility of the branch 3575505-Do-not-allow-selecting-a-disabled-view-display to hidden.

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Needs work » Needs review
StatusFileSize
new screenshot-2026-02-27 11_37_55.png8.62 KB

Alright, this should do the trick:
screenshot

We don't need any logic for the view itself, since we only load views with status set to TRUE.

grevil opened merge request !46

grevil’s picture

grevil commented

Test failures are not related to this issue and should be fixed in #3575357: Fix broken CI Pipeline and fix code style (phpcs. phpstan, styleint, cspell, eslint, ...).

thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented
Assigned: Unassigned » grevil
Status: Needs review » Needs work

LGTM, only the 'disbled' is currently not translatable.

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Needs work » Reviewed & tested by the community

Sorry, fixed!

  • grevil committed 852642fb on 2.1.x 
    feat: #3575505 Do not allow selecting a disabled view display
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.