Problem/Motivation

This is just to target deprecations in themes and misc folder.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3575462

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave’s picture

smustgrave commented
Status: Active » Postponed

Lets wait for theme manager cleanup to happen.

smustgrave opened merge request !14883

smustgrave’s picture

smustgrave commented
Status: Postponed » Needs work

Ok will wait for the theme engine work in #3575467: Remove deprecations related to the theme engine

smustgrave’s picture

smustgrave commented
Status: Needs work » Postponed

On #3352549: Remove deprecations in ajax.js

smustgrave’s picture

smustgrave commented
Status: Postponed » Needs work

Theme engine is covered by #3575467: Remove deprecations related to the theme engine
Ajax.js covered by #3352549: Remove deprecations in ajax.js

So I expanded this to include deprecations in core.libraries which resulted in deleting js-cookie

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Theme engine is merged. Ajax.js still needs work in that other issue.

dcam’s picture

dcam commented
Status: Needs review » Needs work

I assume that the deprecations in misc/ajax.js will have to be kicked down the road again, just like they did in #3464581: Update deprecation notices in ajax.js.

I found a couple of issues and left comments on the MR.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Believe I addressed the feedback.

Having to wait for new commits for random failures sucks

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

My feedback was addressed. LGTM.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

One comment on the MR.

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

Added back + the test coverage for it.

catch closed merge request !14883

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +Needs followup

Thanks that's better. I think we should add a comment there to make it a bit harder to remove like // Do not remove, this is permanent due to serialized data in the database or something.

Everything else looks great. Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 4f51b64b on main 
    refactor: #3575462 Remove deprecations from themes and misc

By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.