Problem/Motivation

Fix broken CI Pipeline, hopefully it's a quick one.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork entity_extra_field-3575357

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

grevil’s picture

grevil commented
Assigned: grevil » Unassigned

Nope, no idea "composer (next major)" seems to fail in several Drupal modules, which have next major testing set up.

I'd wait until D12 actually drops. I bet its an upstream issue.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@grevil can we simply disable it in the .gitlabci.yml? (Sadly that seems to make sense for several projects in general).

Even better would be if gitlab ci could be so clever to only run it on opted-in (compatible) projects...

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Fix broken CI Pipeline » Fix broken CI Pipeline and fix code style (phpcs. phpstan, styleint, cspell, eslint, ...)
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil
grevil’s picture

grevil commented

Even better would be if gitlab ci could be so clever to only run it on opted-in (compatible) projects...

It actually does! But we opted in in several projects. And I still think its a good idea to opt-in! The Job should be simply fixed upstream IMO.

grevil opened merge request !48

grevil’s picture

grevil commented
Assigned: grevil » Unassigned

We have a custom phpstan.neon again...

We can:
- Keep it and ignore the errors
- Remove it
- Keep it and fix the errors (at own risk)

The phpstan errors suggest we should remove if cases that are always true, but I think that is incorrect...

The parent class even has the same checks in place... I'll just remove it.

grevil’s picture

grevil commented
Status: Active » Needs review

All done, please review!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Well done, thanks @grevil!

  • anybody committed a2ee78b3 on 2.1.x authored by grevil 
    feat: #3575357 Fix broken CI Pipeline and fix code style (phpcs. phpstan...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.