Currently, after selecting multiple terms, and then clicking Delete selected terms button at the bottom, it immediately deletes the terms, then display a message for how many terms were deleted.

It would be helpful to have a confirmation step, that lists the names of all terms selected, and Please Confirm or Are You Sure? before actually deleting. If the user Cancels, it would be great to be able to go back to the list with any terms still selected so as to be able to make a tweak to those that were clicked.

We have a couple thousand terms to scroll through and it can be easy to forget exactly which terms that were clicked on as scrolling down the screen... and would be nice to have this one final step to reconcile.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

fizcs3 created an issue. See original summary.

chaitanyadessai made their first commit to this issue’s fork.

chaitanyadessai’s picture

@fizcs3 Please review MR

chaitanyadessai’s picture

Status: Active » Needs review
divya.sejekan’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new31.3 KB

Reviewed the MR!3 . Works well
RTBC++

Steps followed:
1. Enable Bulk term delete module
2. Create taxonomy terms
3. Click on bulk delete
4. Check the confirmation message

fizcs3’s picture

Status: Reviewed & tested by the community » Needs review

Thanks so much @chaitanyadessai and @divya.sejekan

I just reviewed as well. It works, but I noticed a few things:

  1. The commit is changing unrelated logger code and removing the TID's that accompanied the terms in the log... those were useful.
  2. We should also add each TID to the confirm page, such as: $items[] = $term->label() . ' (TID: ' . $term->id() . ')'; to the confirm page.
  3. When I click cancel and go back to the Bulk Delete page, any that were selected are now unselected... might there be an easy way for us to preserve those that were clicked if we were to return to that page on a Cancel?
chaitanyadessai’s picture

Please review..

chaitanyadessai’s picture

StatusFileSize
new429.94 KB
fizcs3’s picture

Status: Needs review » Reviewed & tested by the community

@chaitanyadessai I just tested and all 3 of my concerns above were addressed in the added commit to MR!3 -- this is working great for me, fantastic to be able to preserve what was clicked after cancel, thank you so much!

I should mention also I am on Drupal 10.5.8
Moving to RTBC, unless any other concerns

chaitanyadessai’s picture

Status: Reviewed & tested by the community » Fixed

Fixed and released thanks all.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.