Problem/Motivation

Going to wait for #3575201: Simple deprecation removal from modules part 1 first

These are a little more detailed then part 1 but modules include

> block
> ckeditor5
> field_ui
> page_cache
> language
> content_translation
> filter
> locale
> link

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3575254

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave’s picture

smustgrave commented
Issue summary: View changes

smustgrave opened merge request !14876

smustgrave’s picture

smustgrave commented

Fyi does not include any migration or update_hook related code.

smustgrave’s picture

smustgrave commented
Status: Postponed » Needs work

Part 1 landed

smustgrave’s picture

smustgrave commented
Issue summary: View changes
Status: Needs work » Needs review

Still a few more but MR is pushing the limit so I'll open a final part3 to get any left overs. May hold until after migrations are removed.

smustgrave’s picture

smustgrave commented
Related issues: +#3571060: Remove deprecated code from the Link module
dcam’s picture

dcam commented
Status: Needs review » Needs work

I left a couple of comments on the MR, but I found several other things from untouched files.

There are lingering references to field_ui.module in a few different list builder classes. These references only mention the file name, but were implicitly referring to the deleted field_ui_entity_operation_alter() function. That function was moved to FieldUiHooks::entityOperation(). I suggest that the reference should be updated to the new class AND function. See the following files:

There is a test module, ckeditor5_icon_deprecation_test, that was added for the purpose of testing CKEditor5PluginManagerTest::testDeprecatedIcons(), which we're deleting. There are no other uses. The test module should be deleted.

There is a test module, field_ui_test_deprecated, that is not installed by any test. It may no longer be used. I would include it in the scope of this issue. Also, if I'm right about it not being used then that's kind of sad because maintenance has continued to be performed on this dead code. It underwent the OOP hook conversion in 2024. This drives home the comment I made in Slack about dead test module code. This would mean there's a real cost to it.

FilterThemeHooks::preprocessFilterTips() is deprecated for removal in D12. See https://git.drupalcode.org/project/drupal/-/blob/main/core/modules/filte....

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

I had to ask about preprocessFilterTips() but does seem it's meant to go, the CR didn't really mention it. Nice find with the deprecated modules.

smustgrave’s picture

smustgrave commented

I believe we are down to 3-4 modules left but this MR size is at the border before it's a pain for reviewers

dcam’s picture

dcam commented
Status: Needs review » Needs work

There are a couple of docblock typos to fix. Then this one will be ready.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Applied the suggestions to the MR directly.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

All feedback has been addressed. This looks good to me.

  • catch committed 49c2dc16 on main 
    task: #3575254 Module deprecation removal part2

By: smustgrave
By: dcam
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

fwiw scope was about right here - it's all straightforward removals of code so easy to review in one go. I'm not worrying too much about whether we missed anything because we always end up doing a final sweep anyway.

@dcam's comments about the zombie test modules are interesting. #3502432: Make hook testing with kernel tests very simple would let us get rid of quite a lot of test modules. But also I wonder if we can write a script that collects every test module name, and then checks if they're referenced in any tests or something like that?

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14876

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.