Icon for local tasks not showing

Hi Tim,

I tested the code change on three different Drupal instances.

Drupal core versions: 10.3.14, 10.6.3 and 11.3.3
PHP versions: 8.3.30 (10.3) and 8.4.18 for the newer core versions.
Database version: MariaDB 11.8.6

After adding the patch, I received the following error on all three (when UI icons module is not enabled on the site):

Warning: Undefined array key "icon" in Drupal\navigation_extra\Plugin\Block\NavigationExtraLocalTasksBlock->build() (line 164 of /var/www/html/web/modules/contrib/navigation_extra/src/Plugin/Block/NavigationExtraLocalTasksBlock.php)

Because my configuration does not contain a key "icon" (dump via xdebug):

array (
  'id' => 'navigation_extra_local_tasks',
  'label' => 'Local Tasks',
  'label_display' => 'visible',
  'provider' => 'navigation_extra',
  'primary' => 1,
  'secondary' => 1,
  'context_mapping' => 
  array (
  ),
)

After removing and re-adding the block with UI Icons module enabled, I get the following configuration:

array (
  'id' => 'navigation_extra_local_tasks',
  'label' => 'Local Tasks',
  'label_display' => 'visible',
  'provider' => 'navigation_extra',
  'primary' => 1,
  'secondary' => 1,
  'context_mapping' => 
  array (
  ),
  'icon' => NULL,
)

The problem does reappear after disabling the UI Icons module and adding the block again, so I think that around the icons part in the build, there will likely also needs to be a check to see if the module is enabled before the configuration is retrieved.

I will test choosing an icon now, but wanted to pass on this information already.

Greetings,

Fabio

Hi Tim,

I have tested selecting an icon and this works well. The only comment I have is that the icons in the autocomplete selection list sometimes take up a lot of space.

I think it might be useful to specify a fixed size here so that the icons are always displayed in the same way.

Also noticed that even on a site where UI Icons was already enabled, the error I mentioned earlier occurs, given that the block already existed before the patch was added. So I don't know if my previously mentioned fix will cover the entire load.

Greetings,

Fabio

Hi Tim,

After retesting the adjustments, the array errors are gone, but I still get the following error on the Drupal 10 site:

Error: Call to undefined method Drupal\navigation_extra\Plugin\Block\NavigationExtraLocalTasksBlock::traitSubmitConfigurationForm() in Drupal\navigation_extra\Plugin\Block\NavigationExtraLocalTasksBlock->submitConfigurationForm() (line 111 of /var/www/html/web/modules/contrib/navigation_extra/src/Plugin/Block/NavigationExtraLocalTasksBlock.php).

Allowing icon selection means that the code will not be compatible with both 10.x and 11.x. So perhaps you could split the functionality and, for now, just include the icon and we can create a follow-up issue to allow icon selection?

Greetings,

Fabio

I have created a ticket for this: https://www.drupal.org/project/navigation_extra/issues/3577554