Problem/Motivation

The following have such easy deprecation removals I decided to combine them into one.

> Taxonomy
> Toolbar
> Navigation
> jsonapi
> breakpoint
> contextual
> search
> dblog
> menu_link_content
> media
> media_library
> editor

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3575201

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave’s picture

smustgrave commented
Issue summary: View changes
Related issues: +#3574660: Remove deprecated code from breakpoints module, +#3574421: Remove deprecated code from search module
smustgrave’s picture

smustgrave commented
Issue summary: View changes

smustgrave opened merge request !14871

smustgrave’s picture

smustgrave commented
Issue summary: View changes

Makes a bakers dozen

smustgrave’s picture

smustgrave commented
Issue summary: View changes

So basic_auth had a test failure tied to a test being removed in #3573870: Remove deprecated code from user and basic_auth module so I took that out and moved over there. Replaced with jsonapi here.

smustgrave’s picture

smustgrave commented
Status: Active » Needs review

If core committers accept me grouping like this I'll make a part2 to get the rest

dcam’s picture

dcam commented
Status: Needs review » Needs work

I left a few comments on the MR. I also found one other thing:

There is a lingering reference to _contextual_links_to_id() at https://git.drupalcode.org/project/drupal/-/blob/main/core/modules/setti....

dcam’s picture

dcam commented
Status: Needs work » Reviewed & tested by the community

My feedback was addressed. This looks good to me.

nicxvan’s picture

nicxvan commented

Fun fact regarding 5 a baker's dozen is 13.

The theory was there were severe penalties for providing less than advertised so bakers would include 13 when selling a dozen to account for the variable sizes of baked goods:
https://www.britannica.com/story/why-is-a-bakers-dozen-13

smustgrave’s picture

smustgrave commented

Don't tempt me to add another lol

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

Should the migrate-related cleanup be handled in a follow-up (Part 2)?

SearchConfigurationRankings.php is deprecated and still referenced in the migrate configuration, so I wanted to clarify whether that is intentionally out of scope for this issue.

catch’s picture

catch
he/him
Primary language English
commented

migrate_drupal removal is happening in one go in #3572280: Remove Migrate Drupal so good to exclude from here (and other deprecation removals).

  • catch committed 95147fb9 on main 
    task: #3575201 Simple deprecation removal from modules part 1

By:...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks for combining these.

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14871

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.